Example app update

[Hung6129]

No description provided.

[ghost]

Hello @Hung6129 ,
Thanks for the PR 👍
A few changes before we merge..

[Hung6129]

Oh, about the node name
I think do it earlier it good too
It just i do not know a efficient way to do this 😢
If in the provisioning method where should i call it tho and same with UnprovisionedMeshNode object?
hope you can show me where is the best way to call and expose it
thanks

[ghost]

Hi @Hung6129 ,

Changing the name ealier probably implies to edit some native code and I couldn't find it easily on GitHub to guide you. Maybe we can split your changes : revert the changes on the plugin and only keep changes in example app. If you follow the comments I added then we can merge the example app update and work on choosing name upon provisioning in a separate PR ?

[Hung6129]

Yeah sure !!
Can you tell me when we can start?
And what can i do to make it easier for you?

Btw it was mine first time to create a PR on a repo, hope u can skip out on the mistake 😟

Thanks you

[ghost]

You didn't make any mistakes. Thanks for your contribution 😃

Make a commit on your branch that applies my suggestions and that removes the name change at the end of provisioning. So we can merge the example app update.
Then open a new issue for the feature request about having the newly provisioned node named after the given DiscoveredDevice.

[ghost]

Thx for the removal and for other updates in the issues 👍
There are still some needed changes before we can merge 🚀

[ghost]

Hello @Hung6129

Would you have some time to apply my suggested changes ?
So we can merge your PR ;)

[Hung6129]

Resolve the changes

[ghost]

Thanks 😊 LGTM except the pubspec.lock files update as it implies higher dart sdk constraint