Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario functionality broke after some patch but.. #97

Closed
davv1 opened this issue May 12, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@davv1
Copy link

commented May 12, 2019

but I'm not sure after which patch, or which mod breaks it. I'm still using scenario which was made few months ago, and today after return(last version we played was 0.17.23 iirc) some functionalities don't work, and they are:

  • shared chat(we need to /s like on PvP scenario)
  • all buttons on top panel(only OARC related)

I will extend list as I find more functionalities not working.

Also, I found one "dummy" player entity after one startup, but I just ignored it.

Requesting previous saves is impossible, as we use factorio.zone service, which doesn't allows for autosave-history or something like that. I can only get current logs, or current save from their server for now.

@Oarcinae

This comment has been minimized.

Copy link
Owner

commented May 12, 2019

Hmmm, this is new. I've not seen those kind of failures before. I would definitely suggest restarting fresh if possible when things fail like that.

The dummy char was a bug in the game for one of the versions.

For shared to break, some major things would have to break.

I definitely suggest updating to the latest scenario code just so I know I'm not chasing down old issues.

Let me know if you can reproduce the issue, or have logs or specific crashes.

@davv1

This comment has been minimized.

Copy link
Author

commented May 16, 2019

Everything was working fine before update, but after I updated to f076835, this happened upon loading save:

obraz

Logs: factorio-current.log
Here's save before updating to mentioned commit: click
And save after updating: click

@Oarcinae

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

@davv1 If you're trying to migrate saves, you'll have a bad time since there's a lot of stuff that will break. Either stick with the same scenario code for the whole run, or start a new one. With the experimental versions of factorio and my scenario still in work, I can't guarantee no breaking changes.

@davv1

This comment has been minimized.

Copy link
Author

commented May 16, 2019

Last time it worked perfectly @Oarcinae when you was adding buttons to restart player data.

@Oarcinae

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

I'm not saying it won't work sometimes, but it's something I can't help with because there are just some breaking changes that can't be migrated. Like the one you just posted about can't be fixed. I suggest using an older commit or older save and do not update the scenario code unless you're restarting the map.

@davv1

This comment has been minimized.

Copy link
Author

commented May 17, 2019

Oki.

@davv1 davv1 closed this May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.