You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree it'd be nice if ods_tools supported this natively.
For this PR on Platform, I approve the current implementation with io.BytesIO workaround - we'll update if/when we update the ods_tools API.
Looking at OedExposure, I see there is an OedSource.from_file_path() method that is triggered if the file is a path, but from_file_path only returns an initialised OedSource without actually reading the data from file.
Since OedSource.from_dataframe() loads the data, I think we should just have OedSource.from_file_path() to load the data before returning. @sstruzik can we do that or perhaps open an issue on the ods repo to track this?
The text was updated successfully, but these errors were encountered:
sstruzik
changed the title
Add option to read from binary steams in ods-tools package
Add option to read from binary streams in ods-tools package
Mar 22, 2023
Description
I agree it'd be nice if
ods_tools
supported this natively.For this PR on Platform, I approve the current implementation with
io.BytesIO
workaround - we'll update if/when we update theods_tools
API.Looking at
OedExposure
, I see there is anOedSource.from_file_path()
method that is triggered if the file is a path, butfrom_file_path
only returns an initialisedOedSource
without actually reading the data from file.Since
OedSource.from_dataframe()
loads the data, I think we should just haveOedSource.from_file_path()
to load the data before returning.@sstruzik can we do that or perhaps open an issue on the ods repo to track this?
The text was updated successfully, but these errors were encountered: