Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to read from binary streams in ods-tools package #128

Closed
sambles opened this issue Jan 30, 2023 · 0 comments
Closed

Add option to read from binary streams in ods-tools package #128

sambles opened this issue Jan 30, 2023 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@sambles
Copy link
Contributor

sambles commented Jan 30, 2023

Description

From: OasisLMF/OasisPlatform#724 (comment)

I agree it'd be nice if ods_tools supported this natively.
For this PR on Platform, I approve the current implementation with io.BytesIO workaround - we'll update if/when we update the ods_tools API.

Looking at OedExposure, I see there is an OedSource.from_file_path() method that is triggered if the file is a path, but from_file_path only returns an initialised OedSource without actually reading the data from file.
Since OedSource.from_dataframe() loads the data, I think we should just have OedSource.from_file_path() to load the data before returning.
@sstruzik can we do that or perhaps open an issue on the ods repo to track this?

@sambles sambles added the feature New feature or request label Jan 30, 2023
@sstruzik sstruzik changed the title Add option to read from binary steams in ods-tools package Add option to read from binary streams in ods-tools package Mar 22, 2023
@sambles sambles linked a pull request Mar 30, 2023 that will close this issue
@sambles sambles closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants