Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ord integration #800

Merged
merged 13 commits into from Apr 1, 2021
Merged

Feature/ord integration #800

merged 13 commits into from Apr 1, 2021

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Mar 29, 2021

Analysis settings schema update and integration for Ktools PR195

  • Added ept / psept to bash generation
  • Update bash tests & added ord checks
  • Extended model_settings schema with valid_output_metrics
  • Update analysis_settings schema with ord options
  • Aligned ktools version tag with new ktools release
  • Update schema in OasisPlatform
  • Test ktools in OasisPlatform
  • Test schema validation in OasisPlatform

Supported ORD outputs

Exceedance Probability Table: output/<gul | il |ri>_S<summary_id>_ept.csv

Per Sample Exceedance Probability Table: output/<gul | il | ri>_S<summary_id>_psept.csv

New analysis_settings options

    "gul_summaries": [ 
        {   
            "id": 1,
            "ord_output": { 
                "ept_full_uncertainty_aep": true, 
                "ept_full_uncertainty_oep": true, 
                "ept_mean_sample_aep": true, 
                "ept_mean_sample_oep": true, 
                "ept_per_sample_mean_aep": true, 
                "ept_per_sample_mean_oep": true,                                                                                             
                "psept_aep": true, 
                "psept_oep": true, 
                "return_period_file": true
            }   
        }   
    ],  
  • Using the above will create two files output/gul_S1_ept.csv and output/gul_S1_psept.csv.
  • At least one option from psept_* or ept_* must be set to true for the associated file to be created.
  • Each selected metric will add more data into the linked file type.

Unsupported ORD outputs

The following ORD boolean flags are now part of the analysis_settings.json schema, however they are not supported yet.

    "gul_summaries": [ 
        {   
            "id": 1,
            "ord_output": { 
                "elt_sample": true,
                "elt_quantile": true,
                "elt_moment": true,
                "plt_sample": true,
                "plt_quantile": true,
                "plt_moment": true,
                "alt_period": true,

            }   
        }   
    ],  

@sambles sambles linked an issue Mar 29, 2021 that may be closed by this pull request
Copy link
Contributor

@hchagani-oasislmf hchagani-oasislmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sambles sambles merged commit 61b21e3 into develop Apr 1, 2021
@sambles sambles deleted the feature/ord-integration branch April 1, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend json schema's with new ORD output options
2 participants