Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate model file validation checks when running csv to binary conversion tools #356

Closed
hchagani-oasislmf opened this issue Sep 20, 2023 · 0 comments · Fixed by #370
Assignees
Milestone

Comments

@hchagani-oasislmf
Copy link
Contributor

Issue Description

Model file validation components (see PR #77) run validity checks on the model files damage_bin_dict.csv, footprint.csv and vulnerability.csv. These checks are not performed by the csv to binary conversion tools, and there have been a number of occasions when invalid model files have caused errors in downstream components. While users are encouraged to run these checks before converting files to binary format, it would be prudent to have the binary conversion components execute these checks by default with an option to switch them off.

Version / Environment information

ktools >v3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants