Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event ID should not exceed MAX_INT when converting footprint file from csv to binary #383

Open
hchagani-oasislmf opened this issue May 8, 2024 · 0 comments · May be fixed by #385
Open
Assignees

Comments

@hchagani-oasislmf
Copy link
Contributor

Issue Description

Model file validation checks have been a part of the corresponding csv to binary conversion tools since ktools v3.12.0 (see PR #370). Currently, when using footprinttobin to convert footprint csv files to binary format, there is no check that event ID does not exceed the MAX_INT limit. This can lead to negative event IDs as a result of integer overflow, or even more dangerously positive event IDs that are reported as being 232 less than that in the csv file.

A check for this should be introduced in a similar fashion to the check on vulnerability ID in vulnerabilitytobin.

Version / Environment information

ktools >v3.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant