Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maximum Event ID and Areaperil ID validation checks on footprint files #385

Merged
merged 6 commits into from
May 30, 2024

Conversation

hchagani-oasislmf
Copy link
Contributor

@hchagani-oasislmf hchagani-oasislmf commented May 15, 2024

Introduce maximum Event ID and Areaperil ID validation checks on footprint files

Validation checks have been introduced in the footprinttobin and validatefootprint components to ensure that the Event ID and Areaperil ID do not exceed the maximum integer value. To facilitate this, the method Validate::CheckIDDoesNotExceedMaxLimit() has been created, and allows for similar checks on other IDs to be introduced in the future if required.

@hchagani-oasislmf hchagani-oasislmf changed the title Introduce maximum Event ID validation check on footprint files Introduce maximum Event ID and Areaperil ID validation check on footprint files May 22, 2024
@hchagani-oasislmf hchagani-oasislmf changed the title Introduce maximum Event ID and Areaperil ID validation check on footprint files Introduce maximum Event ID and Areaperil ID validation checks on footprint files May 22, 2024
@hchagani-oasislmf hchagani-oasislmf merged commit 935552c into develop May 30, 2024
2 checks passed
@hchagani-oasislmf hchagani-oasislmf deleted the feature/383-event-ids-less-than-maxint branch May 30, 2024 10:43
@sambles sambles mentioned this pull request May 30, 2024
@awsbuild awsbuild added this to the v3.12.3 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Event ID should not exceed MAX_INT when converting footprint file from csv to binary
2 participants