Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cleanup PR #906 #1

Merged
merged 1 commit into from Mar 5, 2024
Merged

fix: Cleanup PR #906 #1

merged 1 commit into from Mar 5, 2024

Conversation

amannn
Copy link

@amannn amannn commented Mar 5, 2024

I had another deeper look and cleaned up some things along the way. Can you enable edits by maintainers so I can push to your branch?

Cleanup:

  • Share logic for extracting base path
  • Fix mocked location to streamline implementation
  • Clear mocks in test for regression test to work reliably
  • Bump sizes

@amannn
Cleanup:
eacd981 
 - Share logic for extracting base path
 - Fix mocked location to streamline implementation
 - Clear mocks in test for regression test to work reliably
 - Bump sizes
@amannn amannn mentioned this pull request Mar 5, 2024
Merged
@Oberwaditzer Oberwaditzer merged commit 5cf9b1e into Oberwaditzer:fix/905-router-push-with-basepath Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@amannn @Oberwaditzer