Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast #1093

Closed
xenowits opened this issue Sep 7, 2022 · 0 comments · Fixed by #1112
Closed

Add support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast #1093

xenowits opened this issue Sep 7, 2022 · 0 comments · Fixed by #1112
Assignees
@dB2510
Labels
duties This issue is related to duties to be added enhancement New feature or request

Comments

@xenowits
Copy link
Contributor

xenowits commented Sep 7, 2022 •
edited
Loading

Problem to be solved

Add support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast component.

Proposed solution

  • If broadcast DutyPrepareAggregator using SubmitBeaconCommitteeSubscriptionsV2 fails with a 404 error (if the beacon node doesn’t support v2 yet):
    • is_aggregator = eth2exp.CalculateCommitteeSubscriptionResponse()
    • Create a new v1.BeaconCommitteeSubscription{ ..., IsAggregator: is_aggregator} object
    • Broadcast using SubmitBeaconCommitteeSubscriptions (v1).

Out of Scope

None
@xenowits xenowits added the duties This issue is related to duties to be added label Sep 7, 2022
@dB2510 dB2510 added the enhancement New feature or request label Sep 8, 2022
@dB2510 dB2510 self-assigned this Sep 9, 2022
@dB2510 dB2510 mentioned this issue Sep 11, 2022
Merged
@dB2510 dB2510 linked a pull request Sep 11, 2022 that will close this issue
core/bcast: add support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast #1112
Merged
obol-bulldozer bot pushed a commit that referenced this issue Sep 13, 2022
@dB2510
core/bcast: add support for v1.BeaconCommitteeSubscriptionsSubmitter …
bd9bf85 
…to bcast (#1112)

Adds support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast and beaconmock.

category: feature
ticket: #1093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
duties This issue is related to duties to be added enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core/bcast: add support for v1.BeaconCommitteeSubscriptionsSubmitter to bcast ObolNetwork/charon
2 participants
@dB2510 @xenowits