Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor participation metrics to counters #1109

Closed
corverroos opened this issue Sep 10, 2022 · 0 comments
Closed

Refactor participation metrics to counters #1109

corverroos opened this issue Sep 10, 2022 · 0 comments
Assignees

Comments

@corverroos
Copy link
Contributor

corverroos commented Sep 10, 2022

Problem to be solved

Currently our participation metrics are boolean gauges per peer per duty type. This is visualised by red crosses and green checks for the current "participation state" per peer per duty. Red crosses are not good UX in general. It could also be misleading since the peer might have only missed one duty out of many. This is compounded by rare duties like proposals. If a peer doesn't participate in a proposal, then it has a red cross until the next proposal, which might be weeks.

Example with peer "Bar" sometimes not participating.

Peer Attester Proposer
Foo
Bar

Proposed solution

  • Change the boolean gauges into counters.
  • Change visualisation to number of participations per peer per duty per time window.
  • This removes the "stuck red cross" issue.
  • It also relativises participation as a more accurate ratio or sliding scale as opposed to binary greed/red.

Example with peer "Bar" sometimes not participating.

Peer Attestations Proposals
Foo 97 3
Bar 96 2
obol-bulldozer bot pushed a commit that referenced this issue Sep 27, 2022
Adds participation counter metric.
Fixes unexpected event logic for `DutyPrepareAggreagtor`.
Updates simnet dashboard.

category: feature
ticket: #1109
@corverroos corverroos self-assigned this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant