Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DutyAggregator to DutyDB #1115

Closed
dB2510 opened this issue Sep 12, 2022 · 1 comment
Closed

Add support for DutyAggregator to DutyDB #1115

dB2510 opened this issue Sep 12, 2022 · 1 comment
Assignees
@corverroos
Labels
duties This issue is related to duties to be added enhancement New feature or request

Comments

@dB2510
Copy link
Contributor

dB2510 commented Sep 12, 2022

Problem to be solved

We need to add support for DutyAggregator to DutyDB to store aggregated attestation after consensus which would further needed by validatorapi to support GET /eth/v1/validator/aggregate_attestation

Proposed solution

  • Add a switch case for DutyAggregator to Store method in core/dutydb/memory.go.
  • Add relevant unit tests.
@dB2510 dB2510 added enhancement New feature or request duties This issue is related to duties to be added labels Sep 12, 2022
@xenowits xenowits self-assigned this Sep 12, 2022
@xenowits xenowits changed the title Add support DutyAggregator to DutyDB Add support for DutyAggregator to DutyDB Sep 13, 2022
@xenowits xenowits mentioned this issue Sep 19, 2022
Merged
@dB2510 dB2510 assigned corverroos and unassigned xenowits Sep 20, 2022
obol-bulldozer bot pushed a commit that referenced this issue Sep 20, 2022
@corverroos
core/dutydb: add aggregator duty (#1139)
eb44fb3 
Adds support for duty aggregator to dutydb.

category: feature 
ticket: #1115
@dB2510
Copy link
Contributor Author

dB2510 commented Sep 21, 2022

Closed by #1139

@dB2510 dB2510 closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
duties This issue is related to duties to be added enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corverroos @dB2510 @xenowits