Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consensus on generic data #1205

Closed
corverroos opened this issue Sep 29, 2022 · 0 comments
Closed

Consensus on generic data #1205

corverroos opened this issue Sep 29, 2022 · 0 comments
Assignees
@corverroos

Comments

@corverroos
Copy link
Contributor

Problem to be solved

We need to use the consensus package for priority protocol. But the consensus package has been built for core.Duty and core.UnsignedDataSet only.

The priority protocol however would require consensus on slot and pbv1.PriorityResult.

We therefore need to make the consensus component support generic duty/slot identifiers with generic protobuf data.

Proposed solution

Refactor consensus to use an identifier interface, of which core.Duty and Slot would be an implementation.
Refactor consensus to use a data interface, of which core.UnsignedDataSet and pbv1.PriorityResult would be an implementation.

Out of Scope

Integration into priority protocol
@corverroos corverroos self-assigned this Sep 29, 2022
@corverroos corverroos mentioned this issue Sep 30, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 3, 2022
@corverroos
core/consensus: generic protobuf values (#1214)
8bc41ee 
Refactors consensus component to support arbitrary protobuf data types. This is backwards wire compatible with previous versions.

category: feature
ticket: #1205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos