Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth2wrap returns zero slot duration sporadically on shutdown. #1326

Closed
corverroos opened this issue Oct 20, 2022 · 0 comments · Fixed by #1378
Closed

eth2wrap returns zero slot duration sporadically on shutdown. #1326

corverroos opened this issue Oct 20, 2022 · 0 comments · Fixed by #1378

Comments

@corverroos
Copy link
Contributor

🐞 Bug Report

Description

Charon integration tests sporadically fail with "division by zero". This seems due to a shutdown race inside eth2wrap or go-eth2-client that returns 0 for SlotDuration (ie empty Spec).
@corverroos corverroos mentioned this issue Nov 2, 2022
Merged
@corverroos corverroos linked a pull request Nov 2, 2022 that will close this issue
app/eth2wrap: fix cancelled context race #1378
Merged
obol-bulldozer bot pushed a commit that referenced this issue Nov 2, 2022
@corverroos
app/eth2wrap: fix cancelled context race (#1378)
a025b4d 
Fixes a race in `eth2wrap` forkjoin code when context is cancelled before any results are returned. This resulted in `<zero>,nil` being returned which resulted in unexpected behaviour, including "divide by zero".

category: bug
ticket: #1326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app/eth2wrap: fix cancelled context race ObolNetwork/charon
1 participant
@corverroos