Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix very_large smoke test #1471

Closed
dB2510 opened this issue Nov 22, 2022 · 0 comments · Fixed by #1797
Closed

Fix very_large smoke test #1471

dB2510 opened this issue Nov 22, 2022 · 0 comments · Fixed by #1797
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Nov 22, 2022 •
edited
Loading

Problem to be solved

very_large test in testutil/compose/smoke/smoke_test.go takes a lot of time to create keys and then run docker-compose up. It produces some errors like:

Proposed solution

  • These errors can be related to beaconmock configuration for ex: returning deterministic attester duties and 1s slot times.
  • Figure out ideal configuration for beaconmock to fix above mentioned errors with very_large smoke test.
  • Find out right configuration for very_large (like, nodes, threshold, num_validators) such that it is well under smoke_tests timeout of 20m.
  • Error logs can be found in smoke_test github action artefacts, for ex: https://github.com/ObolNetwork/charon/actions/runs/3516395550
@dB2510 dB2510 mentioned this issue Nov 22, 2022
Closed
@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
@dB2510 dB2510 mentioned this issue Feb 11, 2023
Merged
@dB2510 dB2510 linked a pull request Feb 14, 2023 that will close this issue
compose: fix very large smoke test #1797
Merged
obol-bulldozer bot pushed a commit that referenced this issue Feb 14, 2023
@dB2510
compose: fix very large smoke test (#1797)
bc73565 
Enables very large smoke test with 7 of 10 cluster and 100 validators.

category: test
ticket: #1471
gsora added a commit that referenced this issue Feb 20, 2023
@gsora
Squashed commit of the following:
58e203b 
commit a04ce78
Author: Dhruv Bodani <dhruvbodani2510@gmail.com>
Date:   Mon Feb 20 20:04:37 2023 +0530

    *: upgrade to go1.20.1 (#1824)

    Upgrades go version to 1.20.1.

    category: misc
    ticket: #1821

commit c63199e
Author: corver <corver@obol.tech>
Date:   Mon Feb 20 15:36:34 2023 +0200

    gomod: upgrade libp2p  (#1823)

    Upgrades libp2p to v0.25.1

    category: refactor
    ticket: none

commit e3161a3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 20 10:41:34 2023 +0000

    build(deps): Bump golang.org/x/net from 0.6.0 to 0.7.0 (#1822)

    (dependabot) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.6.0 to 0.7.0.

commit ce76297
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 20 10:36:13 2023 +0000

    build(deps): Bump github.com/attestantio/go-eth2-client from 0.15.3 to 0.15.4 (#1819)

    Bumps [github.com/attestantio/go-eth2-client](https://github.com/attestantio/go-eth2-client) from 0.15.3 to 0.15.4.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/c06075ae2b1cce11556e07dde1ff7b650668b80c"><code>c06075a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/attestantio/go-eth2-client/issues/46">#46</a> from attestantio/dvt</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/776af407e5ea768d2e534331cf85a7fb3ac59d59"><code>776af40</code></a> Merge branch 'master' into dvt</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/d21be8e84af4a8e953b996de7818e8698e8bdb2d"><code>d21be8e</code></a> Fixes</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/6a22388d146182276771328f6e415c4fa17bb362"><code>6a22388</code></a> Update http/blindedbeaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/c2b26ac084e7227396e33021bd1035b1a9fdb9b2"><code>c2b26ac</code></a> Update http/blindedbeaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/3ca9b6d4dee2ddfb607808cfcd52862be5ad8f2e"><code>3ca9b6d</code></a> Update http/beaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/9646809365152d3eb7c239d0339e4aac91bef58a"><code>9646809</code></a> Update http/beaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/d29581f31c965436f465c034b56c507c5e0f73e9"><code>d29581f</code></a> Update http/beaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/870a2f3a67465c8a7c2476dc284103d0a05a06e0"><code>870a2f3</code></a> Update http/beaconblockproposal.go</li>
    <li><a href="https://github.com/attestantio/go-eth2-client/commit/097a53c5ef6c46b844c2804693bff3967f99db86"><code>097a53c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/attestantio/go-eth2-client/issues/45">#45</a> from avalkov/support-extra-headers</li>
    <li>Additional commits viewable in <a href="https://github.com/attestantio/go-eth2-client/compare/v0.15.3...v0.15.4">compare view</a></li>
    </ul>
    </details>
    <br />

    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/attestantio/go-eth2-client&package-manager=go_modules&previous-version=0.15.3&new-version=0.15.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)

    ---

    <details>
    <summary>Dependabot commands and options</summary>
    <br />

    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

    </details>

commit bf0f469
Author: corver <corver@obol.tech>
Date:   Fri Feb 17 15:48:09 2023 +0200

    dkg: add deposit data to lock file (#1815)

    Populates the deposit data field in the generated lock files.

    category: feature
    ticket: #1775

commit b16fd01
Author: Gianguido Sorà <gsora@users.noreply.github.com>
Date:   Thu Feb 16 17:45:18 2023 +0100

    p2p: remove pointless "No connections to relay" log line (#1816)

    That log line wasn't useful anyway.

    category: refactor
    ticket: none

commit 14d6b7c
Author: corver <corver@obol.tech>
Date:   Thu Feb 16 17:43:32 2023 +0200

    cluster: draft v1.6 lock with deposit data (#1813)

    Adds a new draft lock version v1.6 which includes deposit data in the lock's distributed validators.

    category: feature
    ticket: #1775

commit d56cfd5
Author: corver <corver@obol.tech>
Date:   Wed Feb 15 16:25:55 2023 +0200

    cmd: route libp2p to charon logger (#1810)

    Fixes issue with libp2p using its own logger. Instead, it now logs via the configured charon logger (incl pushing to loki if enabled).

    category: refactor
    ticket: none

commit f1d260b
Author: corver <corver@obol.tech>
Date:   Wed Feb 15 09:17:04 2023 +0200

    app: add a test for remote relay connections (#1808)

    Adds a test/script to test remote relay connection count.

    category: test
    ticket: none

commit 3c91888
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Feb 14 17:07:50 2023 +0000

    build(deps): Bump go.uber.org/goleak from 1.2.0 to 1.2.1 (#1807)

    (dependabot) Bumps [go.uber.org/goleak](https://github.com/uber-go/goleak) from 1.2.0 to 1.2.1.

commit fbfbfdf
Author: corver <corver@obol.tech>
Date:   Tue Feb 14 17:45:11 2023 +0200

    cmd/relay: fix connection limits (#1805)

    Fixes issue with relay limits not being applied correctly getting stuck at 256 connections.

    category: bug
    ticket: none

commit bc73565
Author: Dhruv Bodani <dhruvbodani2510@gmail.com>
Date:   Tue Feb 14 21:00:09 2023 +0530

    compose: fix very large smoke test (#1797)

    Enables very large smoke test with 7 of 10 cluster and 100 validators.

    category: test
    ticket: #1471

commit 2403c2a
Author: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
Date:   Tue Feb 14 16:48:02 2023 +0530

    validatorapi: fix content type in http response (#1803)

    Fixes sending incorrect `Content-Type` header in HTTP response. Found this bug while integrating nimbus VC which errored when charon sent `text/plain` instead of `application/json`.

    category: bug
    ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compose: fix very large smoke test ObolNetwork/charon
2 participants
@dB2510 @thomasheremans