Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend inclusion delay logic to track failed attestation #1538

Closed
dB2510 opened this issue Dec 12, 2022 · 2 comments
Closed

Extend inclusion delay logic to track failed attestation #1538

dB2510 opened this issue Dec 12, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Dec 12, 2022

Problem to be solved

To track cluster wide failed attestation, currently we need to use external tools like beaconcha.in or rated APIs. Every peer reports failed attestation from tracker component but that reporting is local to each peer. We need a method to track cluster wide failed attestation.

Proposed solution

@dB2510 dB2510 added the enhancement New feature or request label Dec 12, 2022
@corverroos
Copy link
Contributor

What should the initial delay be at startup before we can mark attestations as failed? Since charon only starts tracking blocks from startup (with a delay as well).

@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
@thomasheremans
Copy link
Contributor

First Design Doc

obol-bulldozer bot pushed a commit that referenced this issue Apr 24, 2023
Refactors the inclusion delay tracker to also detect missed inclusions and to log broadcast delay of included and missed duties. The aim is to find a correlation between broadcast performance and inclusion delay.

category: feature
ticket: #1538
obol-bulldozer bot pushed a commit that referenced this issue Apr 24, 2023
When checking attestation and aggregation inclusion, check whether our submissions's aggbits are included in the block attestation aggbits. Also fix matching using attestation data root (not attestation root which changes on additional aggregation). 

category: feature 
ticket: #1538
@corverroos corverroos self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

3 participants