v0.15.0-dev doesn't advertise supported protocols #1948
Assignees
Labels
protocol
Protocol Team tickets
Comments
This was referenced Mar 27, 2023
obol-bulldozer bot
pushed a commit
that referenced
this issue
Mar 28, 2023
Disable dynamic length delimited protocol negotation, postponing it until v0.16.0-dev release. This is because v0.14 still uses the naive `p2p.ProtocolSupported` which doesn't support dynamically negotiated protocols. It only supports the static advertised protocols. Our implementation of the length delimited protocol is dynamically negotiated so not supported by v0.14. The upcoming v0.15.0 release must be compatible with v0.14. category: bug ticket: #1948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Bug Report
Description
We added support for dynamic protocol matching to support both stream-delimited and length-delimited protocols.
This results in v0.14 client-side not being able to detect the supported server-side protocols. This results in peerinfo and some other protocols not to be enabled if one client is v0.14 and the other v0.15.
Proposed solution
See if dynamic protocol matching using
tcpNode.SetStreamHandlerMatchcan by updated to advertise protocols manually.If not, first remove the protocol checking from the client side and remove dynamic matching. Release v0.15. Then add dynamic matching after that for v0.16.
The text was updated successfully, but these errors were encountered: