Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent mutexes from holding locks while doing I/O #2028

Closed
dB2510 opened this issue Apr 5, 2023 · 1 comment
Closed

Prevent mutexes from holding locks while doing I/O #2028

dB2510 opened this issue Apr 5, 2023 · 1 comment
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Apr 5, 2023 •
edited
Loading

🐞 Bug Report

Description

We are noticing sporadic Emit scheduled slot event: epoch already trimmed error logs from scheduler component. This is caused by locking dssMutex:

charon/core/tracker/incldelay.go

Line 35 in b098665

var dssMutex sync.Mutex

Which blocks emitted slot event error log resulting in error getting logged much later. Look for similar problems wherever we added mutexes.

Has this worked before in a previous version?

Yes, the previous version in which this bug was not present was: v0.14.4

🔬 Minimal Reproduction

🔥 Error

Screenshot 2023-04-05 at 3 56 25 PM

🌍 Your Environment

Operating System:

What version of Charon are you running? (Which release)

  
v0.15.0-rc1

Anything else relevant (validator index / public key)?
@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 5, 2023
@dB2510 dB2510 mentioned this issue Apr 5, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 5, 2023
@dB2510
core/tracker: unlock mutex (#2027)
0eca4f6 
Unlock mutex before doing any i/o in core/tracker/incldelay.go.

category: bug
ticket: #2028
dB2510 added a commit that referenced this issue Apr 5, 2023
@dB2510
core/tracker: unlock mutex (#2027)
99c6f29 
Unlock mutex before doing any i/o in core/tracker/incldelay.go.

category: bug
ticket: #2028
@dB2510 dB2510 mentioned this issue Apr 5, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 5, 2023
@dB2510
core/tracker: unlock mutex (#2030)
1dae9e2 
Unlock mutex before doing any i/o in core/tracker/incldelay.go.

category: bug
ticket: #2028 
cherry-pick: #2027
LukeHackett12 pushed a commit that referenced this issue Apr 11, 2023
@dB2510 @LukeHackett12
core/tracker: unlock mutex (#2027)
67a5e4a 
Unlock mutex before doing any i/o in core/tracker/incldelay.go.

category: bug
ticket: #2028
@dB2510 dB2510 self-assigned this May 25, 2023
@dB2510
Copy link
Contributor Author

dB2510 commented May 25, 2023

Closed by #2030

@dB2510 dB2510 closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dB2510