Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Keys Allowed in ENR (OBOL-14) #2054

Closed
1 task
xenowits opened this issue Apr 6, 2023 · 0 comments
Closed
1 task

Duplicate Keys Allowed in ENR (OBOL-14) #2054

xenowits opened this issue Apr 6, 2023 · 0 comments
Assignees
@xenowits
Labels
protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit

Comments

@xenowits
Copy link
Contributor

xenowits commented Apr 6, 2023

🎯 Problem to be solved

The implementation in part of the function Parse() does not check for unqiue keys and overwrites the r.kvs with new values when a duplicate key occurs.

🛠️ Proposed solution

Add a check in each iteration of the above loop to ensure r.kvs does not have an entry for the current key.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
@xenowits xenowits added the sigp audit Issues identified by sigma prime audit label Apr 6, 2023
@xenowits xenowits self-assigned this Apr 6, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 6, 2023
@xenowits xenowits mentioned this issue Apr 10, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 10, 2023
@xenowits
enr: fix duplicate keys in enr parsing (#2073)
e8acdbc 
Adds a check when duplicate keys are found in ENR parsing. Also adds tests.

category: bug 
ticket: #2054
LukeHackett12 pushed a commit that referenced this issue Apr 11, 2023
@xenowits @LukeHackett12
enr: fix duplicate keys in enr parsing (#2073)
174f36c 
Adds a check when duplicate keys are found in ENR parsing. Also adds tests.

category: bug 
ticket: #2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xenowits