Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-generate validator registrations #2172

Closed
2 of 5 tasks
corverroos opened this issue May 10, 2023 · 3 comments
Closed
2 of 5 tasks

Pre-generate validator registrations #2172

corverroos opened this issue May 10, 2023 · 3 comments
Assignees
@gsora @dB2510 @xenowits
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

corverroos commented May 10, 2023 •
edited by dB2510

🎯 Problem to be solved

The current builder-api validator registration endpoint isn't compatible with DV middleware, see #1643 and this design doc.
Changing the spec and getting all VC implementations to implement it is the proper long term solution.

This is short term workaround is to pre-generate validator registration messages during the DKG, to store them in the lock file, and to broadcast them once an epoch when --builder-api=true.

🛠️ Proposed solution

  • Approved design doc: link
  • Core team consensus on the proposed solution

See design doc.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label May 10, 2023
@gsora gsora mentioned this issue May 16, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 16, 2023
@gsora
dkg: pre-generate validator registration messages (#2202)
dd96155 
This functionality lives behind the `pregen_validator_registrations` feature flag.

This PR is only concerned with the DKG pre-generation section of the design document (https://docs.google.com/document/d/1lCYiEv7JmVYymp4CBrEvExj3WNmSqWVvZwl9dwATCmA/edit#).

A follow-up PR will implement the lock file changes and wire it accordingly.

category: feature
ticket: #2172 
feature_flag: pregen_registrations
@dB2510 dB2510 mentioned this issue May 18, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 18, 2023
@dB2510
cluster: add pre-generate registrations to lock v1.7 (#2205)
3af7a70 
Adds pre-generate validator builder registrations to lock file v1.7.0.

category: feature
ticket: #2172
@gsora gsora mentioned this issue May 18, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 19, 2023
@gsora
cmd: generate validator builder registrations (#2208)
0cf9113 
Generate validator builder registrations when running `charon create cluster` manually.

category: feature
ticket: #2172
@gsora gsora mentioned this issue May 19, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 22, 2023
@gsora
cluster/state: support for builder registrations (#2214)
d1f01b4 
This commit includes changes to support validator builder registrations by reading them from the legacy lock file.

category: feature
ticket: #2172
@dB2510 dB2510 mentioned this issue May 22, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 24, 2023
@dB2510
core/bcast: add pre-generate registrations (#2219)
acde3bd 
Adds support to broadcast pre-generate validator registrations through recaster component.

category: feature
ticket: #2172
@boulder225
Copy link
Collaborator

we need a panel to check the outcome once shipped. @OisinKyne FYI

@boulder225
Copy link
Collaborator

https://grafana.monitoring.gcp.obol.tech/d/TcqKfPx4z/engineering-okrs?orgId=1&from=now-90d&to=now

@corverroos corverroos mentioned this issue May 25, 2023
Merged
@boulder225
Copy link
Collaborator

update docs pls @gsora @dB2510

obol-bulldozer bot pushed a commit that referenced this issue May 29, 2023
@corverroos
app: support vmock registrations per epoch (#2238)
bbc46ef 
Refactor validator mock builder-api registrations to align with new pre-generated registrations.

category: refactor
ticket: #2172
@dB2510 dB2510 mentioned this issue Jun 2, 2023
Merged
@dB2510 dB2510 assigned xenowits and unassigned sugh01 Jun 2, 2023
@boulder225 boulder225 mentioned this issue Jun 5, 2023
Open
1 task
@xenowits xenowits mentioned this issue Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsora gsora

@dB2510 dB2510

@xenowits xenowits

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@gsora @sugh01 @corverroos @dB2510 @xenowits @boulder225