Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument supported peer versions #2293

Closed
2 tasks
corverroos opened this issue Jun 8, 2023 · 0 comments
Closed
2 tasks

Instrument supported peer versions #2293

corverroos opened this issue Jun 8, 2023 · 0 comments
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

🎯 Problem to be solved

Charon doesn't currently notify the operator in any way that peers are running incompatible versions while we already detect peer versions in peerinfo protocol and we theoretically know what versions we support.

🛠️ Proposed solution

  • Approved design doc: link

  • Core team consensus on the proposed solution

  • Introduce a proper semver type instead of string parsing.

  • Detect incompatible peer versions in peerinfo protocol and instrument the result.
@github-actions github-actions bot added the protocol Protocol Team tickets label Jun 8, 2023
@corverroos corverroos mentioned this issue Jun 8, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 9, 2023
@corverroos
app/peerinfo: instrument version compatibility (#2295)
c5fe5fc 
Instrument whether peer versions are supported or not.

Introduces a `version.SemVer` type to avoid string wrangling.

category: feature
ticket: #2293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos