Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to view cluster manifests #2381

Closed
3 tasks
xenowits opened this issue Jun 30, 2023 · 0 comments · Fixed by #2408
Closed
3 tasks

Add command to view cluster manifests #2381

xenowits opened this issue Jun 30, 2023 · 0 comments · Fixed by #2408
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

🎯 Problem to be solved

The cluster manifest files are in binary (protobuf) format so is not human readable. But often times, we want to check the contents of a cluster manifest. For example, we may want to check if the manifest contains our new validators after running the add-validators-solo command.

We should provide a way for our users to easily check contents of a cluster manifest file.

🛠️ Proposed solution

Add a new command charon alpha view-cluster-manifest which:

  • loads a manifest file from path specified by the --manifest-file flag
  • reads the cluster data from the file
  • prints the cluster data in a human-readable format (json)

Note that we can probably use the protojson package for this.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Jun 30, 2023
@gsora gsora self-assigned this Jul 6, 2023
obol-bulldozer bot pushed a commit that referenced this issue Jul 11, 2023
Moved some manifest load/store functions to `manifest_tools.go` and generalized them, so we can reuse code across multiple commands.

Closes #2381 

category: feature
ticket: #2381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants