Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create keystore files for new validators #2382

Closed
3 tasks
xenowits opened this issue Jun 30, 2023 · 0 comments
Closed
3 tasks

Create keystore files for new validators #2382

xenowits opened this issue Jun 30, 2023 · 0 comments
Assignees
Labels
protocol Protocol Team tickets

Comments

@xenowits
Copy link
Contributor

🎯 Problem to be solved

The charon alpha add-validators-alpha command doesn't create keystore files (keystore-i.json & keystore-i.txt) for newly created validators.

🛠️ Proposed solution

Create keystore files for each new validator and store them in each node's individual directory:

  • node0/validator_keys
  • node1/validator_keys
  • ....
  • nodeN/validator_keys

Keystore files should be named starting with keystore-<numVals>.json. For example, if a cluster already has 5 validator keys in its validator_keys/ directory and we try adding 2 more, the new keystore files should be:

  • keystore-5.json
  • keystore-5.txt
  • keystore-6.json
  • keystore-6.txt

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Jun 30, 2023
@xenowits xenowits self-assigned this Jul 3, 2023
obol-bulldozer bot pushed a commit that referenced this issue Jul 7, 2023
Write keystores for new validators to disk.

category: feature 
ticket: #2382
@xenowits xenowits closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

1 participant