Soft shutdown not working #2435
Comments
obol-bulldozer bot
pushed a commit
that referenced
this issue
Aug 7, 2023
Fixes soft shutdown by cancelling long running proxied requests. This is because long lived connections are not interrupted by `http.Server.Shutdown`: ``` // Shutdown gracefully shuts down the server without interrupting any // active connections. Shutdown works by first closing all open // listeners, then closing all idle connections, and then waiting // indefinitely for connections to return to idle and then shut down... ``` category: bug ticket: #2435
gsora
pushed a commit
that referenced
this issue
Aug 9, 2023
Fixes soft shutdown by cancelling long running proxied requests. This is because long lived connections are not interrupted by `http.Server.Shutdown`: ``` // Shutdown gracefully shuts down the server without interrupting any // active connections. Shutdown works by first closing all open // listeners, then closing all idle connections, and then waiting // indefinitely for connections to return to idle and then shut down... ``` category: bug ticket: #2435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
馃悶 Bug Report
Description
When stopping the charon docker container it doesn't always do a proper clean soft shutdown. Docker needs to send a sig kill command after 10s for the container to exit.
This is probably related to long running vapi proxy event requests that are not force closed on context cancel.
Proposed Solution
Refactor the proxy in vapi to cancel proxied requests when the application context is closed.
The text was updated successfully, but these errors were encountered: