Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the desired folder exists, before writing the combined keys #2536

Closed
boulder225 opened this issue Aug 11, 2023 · 0 comments
Closed

Ensure the desired folder exists, before writing the combined keys #2536

boulder225 opened this issue Aug 11, 2023 · 0 comments
Labels
candidate candidate for next sprint protocol Protocol Team tickets

Comments

@boulder225
Copy link
Collaborator

boulder225 commented Aug 11, 2023

🎯 Problem to be solved

When the combine command is executed, it writes new combined keys to disk. However, if the target folder does not exist (which is typically the default scenario), the command results in an error.

🛠️ Proposed solution

Before writing the combined keys, the system should ensure that the desired folder exists. If it does not, the folder should be created to allow the combine command to execute without issues.

Incidence

The exact number of occurrences is unknown since we don't have logs specifically for this command. However, no users have raised complaints. This might be because the combine command is seldom used or possibly not by most of our user base.

Impact

Essentially, for the default case, the combine command is broken. This could deter new or existing users who want to utilize this functionality.

@github-actions github-actions bot added the protocol Protocol Team tickets label Aug 11, 2023
@boulder225 boulder225 added the candidate candidate for next sprint label Aug 11, 2023
obol-bulldozer bot pushed a commit that referenced this issue Aug 14, 2023
Ensures the output folder exists before writing combined keys to it.

category: bug
ticket: #2536
dB2510 pushed a commit that referenced this issue Oct 9, 2023
Ensures the output folder exists before writing combined keys to it.

category: bug
ticket: #2536
dB2510 pushed a commit that referenced this issue Oct 9, 2023
Ensures the output folder exists before writing combined keys to it.

category: bug
ticket: #2536
obol-bulldozer bot pushed a commit that referenced this issue Oct 9, 2023
Ensures the output folder exists before writing combined keys to it.

Cherry-pick: #2537 

category: bug
ticket: #2536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate candidate for next sprint protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants