Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charon with updated go-eth2-client #2646

Closed
xenowits opened this issue Oct 18, 2023 · 0 comments
Closed

Fix charon with updated go-eth2-client #2646

xenowits opened this issue Oct 18, 2023 · 0 comments
Assignees
@xenowits
Labels
protocol Protocol Team tickets v0.18.0

Comments

@xenowits
Copy link
Contributor

🎯 Problem to be solved

go-eth2-client is going to release a breaking change. This breaks our existing interfaces.

🛠️ Proposed solution

Update charon to work with the updated eth2-client.

🧪 Tests

None.
@xenowits xenowits self-assigned this Oct 18, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Oct 18, 2023
@xenowits xenowits mentioned this issue Oct 19, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 30, 2023
@xenowits
*: fix compatibility with latest go-eth2-client (#2650)
4632e21 
Fix charon's compatibility with latest release of `go-eth2-client` which contains breaking changes, notably the ETH2 client interface methods. This PR also enables easy integration of deneb fork as the data structures for deneb are included in the new release. An example of the API change is as follows:

Earlier
```
validatorsProvider.Validators(ctx, "head", nil)
```
Now
```
validatorsProvider.Validators(ctx, &api.ValidatorsOpts{
  State: "head",
})
```

Also fix corresponding tests.

category: feature 
ticket: #2646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
protocol Protocol Team tickets v0.18.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xenowits