Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log git commit hash on startup #367

Closed
corverroos opened this issue Apr 6, 2022 · 0 comments
Closed

Log git commit hash on startup #367

corverroos opened this issue Apr 6, 2022 · 0 comments
Assignees
@corverroos
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

corverroos commented Apr 6, 2022 •
edited
Loading

Problem to be solved

Knowing what exact version of the running software is very important and handy for debugging. Currently we only have a hard coded version which isn't exact.

Proposed solution

go1.18 added support vcs.revision and vcs.time to debug.BuildInfo.

  • Add a metric similar to app_version, app_git_commit.
  • Log git_commit_hash and git_commit_time on startup
  • Also print this in version command.
@corverroos corverroos added the enhancement New feature or request label Apr 6, 2022
@corverroos corverroos self-assigned this Apr 6, 2022
@corverroos corverroos mentioned this issue Apr 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 6, 2022
@corverroos
app: log git commit hash (#368)
b029922 
Logs git commit hash and time on startup. Also set commit hash metric and add to version command.

category: feature
ticket: #367
@corverroos corverroos mentioned this issue Apr 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 6, 2022
@corverroos
dockerfile: fix missing git build info (#378)
71ca23f 
Git commit info is only included in build info if a package is built, not a file.

category: bug
ticket: #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos