Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more opencontainer metadata #462

Closed
OisinKyne opened this issue Apr 29, 2022 · 0 comments · Fixed by #480
Closed

Add more opencontainer metadata #462

OisinKyne opened this issue Apr 29, 2022 · 0 comments · Fixed by #480
Assignees
@dB2510
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@OisinKyne
Copy link
Contributor

Problem to be solved

We have the source code metadata key set but nothing else

https://github.com/ObolNetwork/charon/blob/main/Dockerfile#L39

Proposed solution

Add more of the standardised keys https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
@OisinKyne OisinKyne added the enhancement New feature or request label Apr 29, 2022
@corverroos corverroos added the good first issue Good for newcomers label May 3, 2022
@dB2510 dB2510 self-assigned this May 4, 2022
@dB2510 dB2510 mentioned this issue May 5, 2022
Merged
@dB2510 dB2510 linked a pull request May 5, 2022 that will close this issue
dockerfile: add more metadata tags #480
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 5, 2022
@dB2510
dockerfile: add more metadata tags (#480)
44ce408 
Adds some more opencontainer metadata tags to Dockerfile

category: misc
ticket: #462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dockerfile: add more metadata tags ObolNetwork/charon
3 participants
@OisinKyne @corverroos @dB2510