Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBFT: Do not buffer unjust messages #525

Closed
corverroos opened this issue May 13, 2022 · 0 comments
Closed

QBFT: Do not buffer unjust messages #525

corverroos opened this issue May 13, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

Problem to be solved

The current QBFT implementation is buffering ALL messages.
A valid message may however be unjust.
This is either due to a bug in the code, or due to Byzantine behaviour
To err on the side of caution, it should be assumed the be Byzantine, and those messages should not be buffered.

Proposed solution

Move buffering of messages after classification.
Note that classification assumes the message is already in the buffer, create a local var all []Msg slice that includes the latest message (without modifying the buffer itself).

@corverroos corverroos added the enhancement New feature or request label May 13, 2022
@leolara leolara self-assigned this May 14, 2022
obol-bulldozer bot pushed a commit that referenced this issue May 15, 2022
The current QBFT implementation is buffering ALL messages.
A valid message may however be unjust.
This is either due to a bug in the code, or due to Byzantine behaviour
To err on the side of caution, it should be assumed the be Byzantine, and those messages should not be buffered.

category: refactor
ticket: #525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants