Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add flags for withdrawal address and network #555

Closed
xenowits opened this issue May 17, 2022 · 0 comments
Closed

cmd: add flags for withdrawal address and network #555

xenowits opened this issue May 17, 2022 · 0 comments
Milestone

Comments

@xenowits
Copy link
Contributor

xenowits commented May 17, 2022

Problem to be solved

  • Add following flags to charon create cluster command:
    • -withdrawal-address
      • Must verify it's a 42 char string like ^0x()*40 or however the appropriate regex works. Basically the exact same as dkg-poc approach to verification (including checksum if address is mixed case, warn if non-checksummed address). See this.
      • For verify an address, we can use this verification.
      • We can make this a required flag, no defaults. OR,
      • We can make a zero address default withdrawal credential. In that case, remove both gnosis and mainnet from the network options.
    • --network: any network from this list [mainnet, prater, kintsugi, kiln, gnosis]

Proposed solution

Refactor cmd.runCreateCluster to include these flags.

@dB2510 dB2510 added this to the Devnet 2 milestone May 18, 2022
obol-bulldozer bot pushed a commit that referenced this issue May 18, 2022
Add flags for `withdrawal-address` and `network` in `charon create cluster`.

category: feature
ticket: #555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants