Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootnode: circuit reservation resource issues #580

Closed
corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #640
Closed

bootnode: circuit reservation resource issues #580

corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #640
Assignees
@dB2510
Labels
bug Something isn't working
Milestone
Devnet 2

Comments

@corverroos
Copy link
Contributor

corverroos commented May 23, 2022 •
edited
Loading

Problem to be solved

When using the bootnode for libp2p circuit relay, nodes pre-emptively reserve circuits on the bootnode for incoming circuit relay connections. By default, the bootnode only allows 4 reservations per node, each is kept alive for 1 hour.

Since nodes do to not cancel the reservations on exit, they quickly get a RESERVATION_NOT_ALLOWED error if they are restarted more than 4 times per hour.

Proposed solution

  • Either figure out a way to solve this on the client/node side, by either cancelling reservations on shutdown, or by continuing with existing reservations if found on startup.
  • If that doesn't work, fix this on the bootnode by increasing the number of allowed reservations per peer and by decreasing the timeout to 2min. Since nodes refresh reservations every 2 min (due to other resource limitations in the reservation).
  • make bootnode config configurable.
@corverroos corverroos added the bug Something isn't working label May 23, 2022
@dB2510 dB2510 self-assigned this May 26, 2022
@dB2510 dB2510 added this to the Devnet 2 milestone May 26, 2022
@dB2510 dB2510 mentioned this issue May 31, 2022
Merged
@dB2510 dB2510 linked a pull request May 31, 2022 that will close this issue
cmd/bootnode: fixes circuit reservation resource issues #640
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 1, 2022
@dB2510
cmd/bootnode: fixes circuit reservation resource issues (#640)
975163c 
Adds flags to modify max reservations per peer and relay timeout.

category: bug
ticket: #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working
Projects
None yet
Milestone
Devnet 2
Development

Successfully merging a pull request may close this issue.

cmd/bootnode: fixes circuit reservation resource issues ObolNetwork/charon
3 participants
@Battenfield @corverroos @dB2510