Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: ensure valid withdrawal address during create dkg command #582

Closed
corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #599
Closed

cmd: ensure valid withdrawal address during create dkg command #582

corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #599
Assignees
@dB2510
Labels
bug Something isn't working

Comments

@corverroos
Copy link
Contributor

corverroos commented May 23, 2022 •
edited
Loading

Problem to be solved

The current charon create dkg command doesn't do validation of the withdrawal address. A empty withdrawal address is not supported by charon dkg.

Proposed solution

Add a default 0x00..00dead withdrawal address to charon create dkg.
Also verify the address.
@corverroos corverroos added the bug Something isn't working label May 23, 2022
@dB2510 dB2510 self-assigned this May 23, 2022
@dB2510 dB2510 mentioned this issue May 24, 2022
Merged
@dB2510 dB2510 linked a pull request May 24, 2022 that will close this issue
cmd: validate withdrawal address for create dkg command #599
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 24, 2022
@dB2510
cmd: validate withdrawal address for create dkg command (#599)
a2fd562 
Adds a validation for withdrawal address for create dkg command.

category: bug
ticket: #582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: validate withdrawal address for create dkg command ObolNetwork/charon
2 participants
@corverroos @dB2510