Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate cluster definition and lock files #589

Closed
corverroos opened this issue May 23, 2022 · 0 comments
Closed

Validate cluster definition and lock files #589

corverroos opened this issue May 23, 2022 · 0 comments
Assignees
@corverroos
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

Problem to be solved

The cluster definition and cluster lock files contain hashes and signatures. But we neither validate the hash nor the signature in charon dkg or charon run commands.

Proposed solution

In DKG and RUN:

  • Validate the cluster definition hash
  • Validate the cluster definition operator signatures

In RUN:

  • Validate the cluster lock hash
  • Validate the cluster lock aggregate signature

Add a --no-verify flag to both DKG and RUN to disable the validation for local testing.
@corverroos corverroos added the enhancement New feature or request label May 23, 2022
@corverroos corverroos changed the title Validator cluster definition and lock files Validate cluster definition and lock files May 23, 2022
@xenowits xenowits self-assigned this May 31, 2022
@xenowits xenowits removed their assignment Jun 22, 2022
@xenowits xenowits mentioned this issue Jun 23, 2022
Merged
@corverroos corverroos mentioned this issue Aug 22, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Aug 23, 2022
@corverroos
cluster: verify config signatures (#1014)
d9419e5 
Adds `--no-verify` flags to `charon run` and `charon dkg`. Verify config otherwise.

Note that `charon create cluster` requires `--no-verify` since it doesn't sign the generated lock file.
 
category: feature
ticket: #589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corverroos corverroos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Battenfield @corverroos @xenowits @thomasheremans