Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: remove --p2p-peerdb flag #644

Closed
xenowits opened this issue May 31, 2022 · 0 comments
Closed

p2p: remove --p2p-peerdb flag #644

xenowits opened this issue May 31, 2022 · 0 comments

Comments

@xenowits
Copy link
Contributor

xenowits commented May 31, 2022 •
edited
Loading

Problem to be solved

--p2p-peerdb flag: Path to store a discv5 peer database. Empty default results in in-memory database.

Investigate if it can be removed to keep the number of flags to a minimum.

Proposed solution

Remove the flag and its relevant usage based on investigation.
@xenowits xenowits mentioned this issue Jun 2, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 2, 2022
@xenowits
flags: remove peerdb flag (#657)
7dc7a73 
Remove `--p2p-peerdb` flag, so `peerDB` now defaults to a new in-memory database.

category: refactor
ticket: #644
@xenowits xenowits closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Battenfield @xenowits