Flapy test in monitoringapi_internal_test

[dB2510]

Problem to be solved

A test named peer_ping_failing is flapping in monitoringapi_internal_test: https://github.com/ObolNetwork/charon/runs/7615741168?check_suite_focus=true which is responsible to assert error obtained from ready function if peer is not able to connect to quorum number of peers. The problem lies here:

charon/app/monitoringapi_internal_test.go

Line 113 in e7e9998

require.Eventually(t, func() bool {

which expects test to complete in 100ms. This test is non-deterministic since it depends on mutex to result in desired error.

Proposed solution

Make this test deterministic by determining what is the ideal duration to check in require.Eventually function.