Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set threshold automatically in charon create dkg #894

Closed
OisinKyne opened this issue Aug 2, 2022 · 0 comments · Fixed by #917
Closed

Set threshold automatically in charon create dkg #894

OisinKyne opened this issue Aug 2, 2022 · 0 comments · Fixed by #917
Assignees
@dB2510
Labels
enhancement New feature or request

Comments

@OisinKyne
Copy link
Contributor

Problem to be solved

Setting the threshold of a cluster is a nuanced matter, it should have a sensible default as best practice. (In fact, we don't intend to let anyone run this with a value that is not exactly a threshold of quorum)

Proposed solution

Auto select the threshold for a DKG based on the number of ENRs provided. (Consider removing the command entirely (don't hugely feel this is needed right now personally, idk)

Out of Scope

If there is anything to highlight as out of scope for this issue, please outline it here.
@OisinKyne OisinKyne added the enhancement New feature or request label Aug 2, 2022
@dB2510 dB2510 mentioned this issue Aug 5, 2022
Merged
@dB2510 dB2510 linked a pull request Aug 5, 2022 that will close this issue
cmd: safe default threshold #917
Merged
obol-bulldozer bot pushed a commit that referenced this issue Aug 8, 2022
@dB2510
cmd: safe default threshold (#917)
e0dbee4 
Refactors `--threshold` flag to default to safe value if zero. Add logging if unsafe override provided.

category: refactor
ticket: #894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: safe default threshold ObolNetwork/charon
3 participants
@OisinKyne @dB2510 @xenowits