Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retryer should be more transparent #959

Closed
corverroos opened this issue Aug 11, 2022 · 0 comments
Closed

Retryer should be more transparent #959

corverroos opened this issue Aug 11, 2022 · 0 comments
Assignees

Comments

@corverroos
Copy link
Contributor

Problem to be solved

Currently a log of errors or warning are logged by retryer when something fails. Like when broadcasting fails or when duty expires.

  • These errors are logged with topic retryer, which make it hard to identify what is going wrong.
  • Expired duties are logged as "Timeout retrying foo bar, ...., context expired", which could be improved.

Proposed solution

  • Use the topic of the service being wrapped, so it fetcher is failing, then log retry warning with fetcher topic.
  • When duties expire, prefix errors with Duty expired during foo bar, ...., context expired. Distinguish between externa context canceled and duty expiry.
@xenowits xenowits self-assigned this Oct 10, 2022
@xenowits xenowits removed their assignment Oct 12, 2022
obol-bulldozer bot pushed a commit that referenced this issue Oct 17, 2022
Improve logging of retry component:
 - Use topic of component being retried
 - Do not log on shutdown

category: refactor
ticket: #959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants