Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log all flags on startup #995

Closed
corverroos opened this issue Aug 18, 2022 · 0 comments · Fixed by #1249
Closed

Log all flags on startup #995

corverroos opened this issue Aug 18, 2022 · 0 comments · Fixed by #1249
Assignees
@dB2510
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

corverroos commented Aug 18, 2022 •
edited
Loading

Problem to be solved

Charon has a lot of flags, many of which have default values. It can be hard to debug incorrect config or weird errors for values not defined by the users.

E.g. .charon/charon-enr-private-key not found or error resolving bootnode ENR bootnode.gcp.obol.techeven though they never specific anything of that sort.

Proposed solution

Log all flag (config) values at startup at info level.
Either do this a single log (hard to read) or each value on its own line (very verbose).
Do this for bootnode, dkg and run.
@corverroos corverroos added the enhancement New feature or request label Aug 18, 2022
@xenowits xenowits self-assigned this Aug 18, 2022
@xenowits xenowits removed their assignment Sep 26, 2022
@dB2510 dB2510 mentioned this issue Oct 11, 2022
Merged
@dB2510 dB2510 linked a pull request Oct 11, 2022 that will close this issue
cmd: log all flags on startup #1249
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 11, 2022
@dB2510
cmd: log all flags on startup (#1249)
a64b4f6 
Add logging of all flags on startup to bootnode, dkg and run commands.

category: feature
ticket: #995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: log all flags on startup ObolNetwork/charon
3 participants
@corverroos @dB2510 @xenowits