app/eth2wrap: implement parallel multi beacon client #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Aug 22, 2022
| @@ -88,3 +88,13 @@ func (s structured) Stack() zap.Field { | |||
| func (s structured) Unwrap() error { | |||
| return s.err | |||
| } | |||
|
|
|||
| // Is returns true if err is equaled to this structured error. | |||
| func (s structured) Is(err error) bool { | |||
There was a problem hiding this comment.
found this issue with our error package, so fixed it
Codecov Report
@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 54.16% 52.78% -1.39%
==========================================
Files 118 123 +5
Lines 13215 13661 +446
==========================================
+ Hits 7158 7211 +53
- Misses 5030 5419 +389
- Partials 1027 1031 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dB2510
approved these changes
Aug 23, 2022
| } | ||
|
|
||
| func (m multi) Address() string { | ||
| // TODO(corver): return "best" address. |
There was a problem hiding this comment.
i assume this will come in subsequent PRs or it will be taken as part of separate issue?
There was a problem hiding this comment.
can do as separate issue I think
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a parallel eth2 client to improve beacon node latency by using the "fastest" response.
category: feature
ticket: #960