cluster: skip verification if locally created #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 54.02% 53.75% -0.28%
==========================================
Files 124 124
Lines 13791 13913 +122
==========================================
+ Hits 7451 7479 +28
- Misses 5295 5376 +81
- Partials 1045 1058 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
corverroos
added
the
merge when ready
xenowits
reviewed
Aug 23, 2022
| @@ -155,6 +162,10 @@ func (d Definition) Verify() error { | |||
| } | |||
| } | |||
|
|
|||
| if noSigs > 0 && noSigs != len(d.Operators) { | |||
There was a problem hiding this comment.
so, either no one signs OR all of them sign, only then we consider it verified?
There was a problem hiding this comment.
hope we have tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification of unsigned
charon create clusterlock files succeed avoiding the need for--no-verify.category: bug
ticket: #1025