app: add metric for threshold and num validators #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 53.78% 53.42% -0.37%
==========================================
Files 125 125
Lines 13971 13974 +3
==========================================
- Hits 7514 7465 -49
- Misses 5398 5453 +55
+ Partials 1059 1056 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
corverroos
reviewed
Aug 31, 2022
app/metrics.go
Outdated
| @@ -55,11 +69,13 @@ var ( | |||
| }) | |||
| ) | |||
|
|
|||
| func initStartupMetrics(lockHash string) { | |||
| func initStartupMetrics(lockHash string, threshold, numValidators int) { | |||
There was a problem hiding this comment.
add one for peer_name as well 🙏
corverroos
approved these changes
Aug 31, 2022
xenowits
force-pushed
the
xenowits/add-t-n-grafana
branch
from
ee8f817
to
650075c
Compare
|
The update simnet dashboard. |
xenowits
added
merge when ready
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metric for
threshold,num_validatorsandpeer_name.category: misc
ticket: ObolNetwork/charon-distributed-validator-node#65