Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: verify p2pkey before starting libp2p #1157

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Fail fast when p2pkey doesn't match any lock file operator ENRs.

category: feature
ticket: #937

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 53.33% // Head: 53.23% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (5e83606) compared to base (80c43f6).
Patch coverage: 47.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   53.33%   53.23%   -0.10%     
==========================================
  Files         131      131              
  Lines       15269    15292      +23     
==========================================
- Hits         8143     8141       -2     
- Misses       5960     5977      +17     
- Partials     1166     1174       +8     
Impacted Files Coverage Δ
app/app.go 57.45% <47.82%> (-4.39%) ⬇️
core/dutydb/memory.go 66.38% <0.00%> (-0.85%) ⬇️
core/qbft/qbft.go 81.54% <0.00%> (+0.42%) ⬆️
app/vmock.go 76.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 23, 2022
@obol-bulldozer obol-bulldozer bot merged commit 5840bbe into main Sep 23, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/verifyp2pkey branch September 23, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants