Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/promauto: also wrap built-in metrics #1165

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Refactors promauto to simply cache created metrics and return a newly created registry including built-in process metrics.

category: refactor
ticket: #1142

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 53.01% // Head: 53.19% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (95c4a2a) compared to base (7527989).
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   53.01%   53.19%   +0.17%     
==========================================
  Files         132      132              
  Lines       15398    15408      +10     
==========================================
+ Hits         8163     8196      +33     
+ Misses       6050     6021      -29     
- Partials     1185     1191       +6     
Impacted Files Coverage Δ
app/app.go 58.09% <40.00%> (-0.58%) ⬇️
app/promauto/promauto.go 40.35% <51.85%> (+0.35%) ⬆️
app/monitoringapi.go 76.28% <100.00%> (+0.49%) ⬆️
dkg/transport.go 53.70% <0.00%> (-12.97%) ⬇️
app/vmock.go 74.00% <0.00%> (-4.00%) ⬇️
core/dutydb/memory.go 66.38% <0.00%> (-0.85%) ⬇️
core/qbft/qbft.go 81.54% <0.00%> (+9.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 26, 2022
@obol-bulldozer obol-bulldozer bot merged commit ae2d3d9 into main Sep 26, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/promauto2 branch September 26, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants