core/parsigdb: add support for DutySyncMessage to parsigdb #1219
Conversation
Codecov ReportBase: 53.01% // Head: 52.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 53.01% 52.70% -0.31%
==========================================
Files 133 136 +3
Lines 15784 15988 +204
==========================================
+ Hits 8368 8427 +59
- Misses 6198 6326 +128
- Partials 1218 1235 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
core/parsigdb/memory.go
Outdated
| @@ -125,6 +130,31 @@ func (db *MemDB) StoreExternal(ctx context.Context, duty core.Duty, signedSet co | |||
| return nil | |||
| } | |||
|
|
|||
| func shouldOutput(duty core.Duty, sigs []core.ParSignedData, threshold int) (bool, []core.ParSignedData, error) { | |||
There was a problem hiding this comment.
result ordering []core.ParSignedData, bool, error
There was a problem hiding this comment.
rename to calculateOutput
core/parsigdb/memory.go
Outdated
| @@ -125,6 +130,31 @@ func (db *MemDB) StoreExternal(ctx context.Context, duty core.Duty, signedSet co | |||
| return nil | |||
| } | |||
|
|
|||
| func shouldOutput(duty core.Duty, sigs []core.ParSignedData, threshold int) (bool, []core.ParSignedData, error) { | |||
| if duty.Type != core.DutySyncMessage { | |||
| return len(sigs) >= threshold, sigs, nil | |||
There was a problem hiding this comment.
it was len(sigs) == threshold previously
core/parsigdb/memory.go
Outdated
| return len(sigs) >= threshold, sigs, nil | ||
| } | ||
|
|
||
| data := make(map[string][]core.ParSignedData) |
There was a problem hiding this comment.
no need for string key, use eth2p0.Root
core/parsigdb/memory.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if !ok { |
dB2510
added
the
merge when ready
Adds support for
DutySyncMessageto parsigdb.category: feature
ticket: #1192