core/validatorapi: add sync committee duties to validatorapi #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.78% // Head: 53.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 53.78% 53.87% +0.08%
==========================================
Files 139 139
Lines 16457 16486 +29
==========================================
+ Hits 8852 8882 +30
+ Misses 6342 6338 -4
- Partials 1263 1266 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
reviewed
Oct 13, 2022
core/validatorapi/eth2types.go
Outdated
|
|
||
| // syncCommitteeDutiesRequest defines the request to the getSyncCommitteeDuties endpoint. | ||
| // See https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/getSyncCommitteeDuties. | ||
| type syncCommitteeDutiesRequest []eth2p0.ValidatorIndex |
There was a problem hiding this comment.
rather just rename attesterDutiesRequest to valIndexesJSON and re-use that type.
core/validatorapi/router.go
Outdated
| } | ||
|
|
||
| if len(data) == 0 { | ||
| data = []*eth2v1.SyncCommitteeDuty{} |
There was a problem hiding this comment.
is this really required? why isn't nil fine?
| } | ||
|
|
||
| // Replace root public keys with public shares. | ||
| for i := 0; i < len(duties); i++ { |
corverroos
approved these changes
Oct 13, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sync committee duties to validatorapi.
category: feature
ticket: #1261