testutil/validatormock: integrate DutySyncMessage #1293
Conversation
Codecov ReportBase: 53.85% // Head: 53.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
- Coverage 53.85% 53.67% -0.18%
==========================================
Files 139 140 +1
Lines 16477 16803 +326
==========================================
+ Hits 8873 9019 +146
- Misses 6341 6510 +169
- Partials 1263 1274 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -51,7 +52,7 @@ type HTTPMock interface { | |||
| eth2client.SlotDurationProvider | |||
| eth2client.SlotsPerEpochProvider | |||
| eth2client.SpecProvider | |||
| eth2client.SyncCommitteeDutiesProvider | |||
| eth2client.SyncCommitteeSubscriptionsSubmitter | |||
There was a problem hiding this comment.
no other submitters here... probably not required
| @@ -367,6 +367,37 @@ func WithNoAttesterDuties() Option { | |||
| } | |||
| } | |||
|
|
|||
| func WithSyncCommitteeDuties() Option { | |||
There was a problem hiding this comment.
add a comment what this does. Suggest just turning this duty on always if called?
There was a problem hiding this comment.
for simnet?
like adding it in app.go at the time of instantiating beaconmock
dB2510
added
the
merge when ready
Integrates DutySyncMessage by adding support to validatormock and adds a simnet_test.
category: feature
ticket: #1261