Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: instrument not ready reasons #1302

Merged
merged 4 commits into from
Oct 17, 2022
Merged

app: instrument not ready reasons #1302

merged 4 commits into from
Oct 17, 2022

Conversation

corverroos
Copy link
Contributor

Instruments not ready reasons for improved UX.
Also fix a "concurrent map write" panic in peerinfo.

category: feature
ticket: #999

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 53.26% // Head: 53.34% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (4f60ab9) compared to base (c2a8f27).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
+ Coverage   53.26%   53.34%   +0.07%     
==========================================
  Files         140      140              
  Lines       16839    16843       +4     
==========================================
+ Hits         8970     8985      +15     
+ Misses       6593     6587       -6     
+ Partials     1276     1271       -5     
Impacted Files Coverage Δ
app/metrics.go 83.33% <ø> (ø)
app/peerinfo/peerinfo.go 54.48% <0.00%> (-1.55%) ⬇️
app/monitoringapi.go 76.28% <71.42%> (ø)
core/scheduler/scheduler.go 72.94% <0.00%> (-0.54%) ⬇️
core/priority/prioritiser.go 64.76% <0.00%> (+1.03%) ⬆️
core/leadercast/transport.go 76.33% <0.00%> (+1.18%) ⬆️
app/vmock.go 79.14% <0.00%> (+6.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

app/metrics.go Outdated Show resolved Hide resolved
Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

corverroos and others added 2 commits October 17, 2022 15:26
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 17, 2022
@obol-bulldozer obol-bulldozer bot merged commit 952e371 into main Oct 17, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/readyzreasons branch October 17, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants