core/fetcher: add support for DutySyncContribution
#1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.64% // Head: 53.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 53.64% 53.67% +0.03%
==========================================
Files 142 142
Lines 17265 17381 +116
==========================================
+ Hits 9261 9329 +68
- Misses 6714 6753 +39
- Partials 1290 1299 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
force-pushed
the
xenowits/fetcher
branch
from
2c148b6
to
7338411
Compare
corverroos
reviewed
Oct 26, 2022
xenowits
force-pushed
the
xenowits/fetcher
branch
from
b66a9ec
to
0f4ef14
Compare
corverroos
approved these changes
Oct 26, 2022
xenowits
added
the
merge when ready
dB2510
reviewed
Oct 27, 2022
Comment on lines
+816
to
+821
| data := altair.SyncAggregatorSelectionData{ | ||
| Slot: s.Slot, | ||
| SubcommitteeIndex: uint64(s.SubcommitteeIndex), | ||
| } | ||
|
|
||
| return data.HashTreeRoot() |
There was a problem hiding this comment.
this can be done inline:
return altair.SyncAggregatorSelectionData{
Slot: s.Slot,
SubcommitteeIndex: uint64(s.SubcommitteeIndex),
}.HashTreeRoot()
dB2510
reviewed
Oct 27, 2022
| @@ -807,6 +807,72 @@ func (s *BeaconCommitteeSelection) UnmarshalJSON(input []byte) error { | |||
| return s.BeaconCommitteeSelection.UnmarshalJSON(input) | |||
| } | |||
|
|
|||
| // SyncCommitteeSelection wraps an eth2exp.SyncCommitteeSelection and implements SignedData. | |||
| type SyncCommitteeSelection struct { | |||
There was a problem hiding this comment.
add type assertion on top of this file for this type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
DutySyncContributionto fetcher.category: feature
ticket: #1266