scheduler: implement v0 scheduler #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
added a commit
that referenced
this pull request
Feb 25, 2022
Adds the DutyArg and DutyArgSet types to the scheduler and fetcher components in architecture doc. It became evident in #137 that the fetcher needs arguments to fetch the duty data, not just the duty itself (e.g. committee_index for DutyAttester). Since this is what the scheduler already does, it should pass it along with the duty to the fetcher.
Codecov Report
@@ Coverage Diff @@
## corver/tblspukey #137 +/- ##
====================================================
- Coverage 52.34% 46.28% -6.07%
====================================================
Files 29 30 +1
Lines 1725 1951 +226
====================================================
Hits 903 903
- Misses 735 961 +226
Partials 87 87
Continue to review full report at Codecov.
|
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the first version of the scheduler. For now it just has an integration test. Will improve godocs and add more tests in subsequent PRs if we are happy with the approach.
category: feature
ticket: #145