Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add sync committee duties to proto #1375

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 1, 2022

Adds support for sync committee duties data to proto.

category: refactor
ticket: #1263

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 53.88% // Head: 54.07% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (c75a2e8) compared to base (8bf8ab0).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   53.88%   54.07%   +0.19%     
==========================================
  Files         144      144              
  Lines       17661    17679      +18     
==========================================
+ Hits         9516     9560      +44     
+ Misses       6835     6804      -31     
- Partials     1310     1315       +5     
Impacted Files Coverage Δ
core/eth2signeddata.go 80.95% <ø> (ø)
core/signeddata.go 44.12% <ø> (+0.30%) ⬆️
core/proto.go 61.90% <50.00%> (-1.06%) ⬇️
core/unsigneddata.go 47.96% <50.00%> (+0.98%) ⬆️
app/vmock.go 75.40% <0.00%> (-3.75%) ⬇️
core/scheduler/scheduler.go 73.38% <0.00%> (-1.20%) ⬇️
app/app.go 60.21% <0.00%> (-0.87%) ⬇️
core/dutydb/memory.go 69.28% <0.00%> (+0.69%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 1, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4b89587 into main Nov 1, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/syncproto branch November 1, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants