Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add table tests for simnet #1390

Merged
merged 6 commits into from
Nov 9, 2022
Merged

app: add table tests for simnet #1390

merged 6 commits into from
Nov 9, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 7, 2022

Adds table tests for simnet mock VCs.

category: test
ticket: #921

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 53.18% // Head: 52.77% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (f6eeb8a) compared to base (04760c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   53.18%   52.77%   -0.41%     
==========================================
  Files         145      146       +1     
  Lines       18226    18301      +75     
==========================================
- Hits         9694     9659      -35     
- Misses       7199     7305     +106     
- Partials     1333     1337       +4     
Impacted Files Coverage Δ
testutil/beaconmock/options.go 33.86% <0.00%> (-0.56%) ⬇️
core/qbft/qbft.go 72.26% <0.00%> (-9.25%) ⬇️
app/vmock.go 72.87% <0.00%> (-3.73%) ⬇️
app/eth2wrap/eth2wrap.go 59.84% <0.00%> (-1.88%) ⬇️
testutil/beaconmock/beaconmock.go 47.93% <0.00%> (-1.22%) ⬇️
cluster/definition.go 61.70% <0.00%> (-0.41%) ⬇️
app/app.go 61.87% <0.00%> (-0.35%) ⬇️
app/eth2wrap/httpwrap.go 0.00% <0.00%> (ø)
app/eth2wrap/eth2wrap_gen.go 12.73% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 9, 2022
@obol-bulldozer obol-bulldozer bot merged commit d9c124d into main Nov 9, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/tablesimnet branch November 9, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants